Should not remove props from options passed to init#146
Open
kroleg wants to merge 1 commit intokylefarris:masterfrom
Open
Should not remove props from options passed to init#146kroleg wants to merge 1 commit intokylefarris:masterfrom
kroleg wants to merge 1 commit intokylefarris:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My use case is like this: I need to re-init on scanning in case previously init failed. I am forced to use init like
new NodeClam().init({ ...this.settings })to preserve my settings props.Also i think it's generally not recommended to modify args passed to a function. There is even a eslint rule for this: https://eslint.org/docs/latest/rules/no-param-reassign